-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[checklists] Render times in UTC, fix typo, add @never_cache #2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nessita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added some comments. Thanks! 🌟
checklists/templates/checklists/release-security-prenotification.md
Outdated
Show resolved
Hide resolved
| User-agent: * | ||
| Disallow: /admin | ||
| Disallow: /admin | ||
| Disallow: /checklists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we don't have @login_required on all views.
1cef438 to
dbff5b7
Compare
|
Good call on the |
nessita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🏅
When developing this in https://github.com/nessita/checklist-generator, we used modern project defaults for
TIME_ZONE = 'UTC'.dp.com uses
"America/Chicago".And a typo fix.
And
@never_cachedecorators.